On 4/19/23 3:30?PM, kernel test robot wrote: > Hi luhongfei, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on linus/master] > [also build test ERROR on v6.3-rc7 next-20230418] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539 > patch link: https://lore.kernel.org/r/20230419092233.56338-1-luhongfei%40vivo.com > patch subject: [PATCH] io_uring: Optimization of buffered random write > config: i386-randconfig-a012-20230417 (https://download.01.org/0day-ci/archive/20230420/202304200502.T4Waeqad-lkp@xxxxxxxxx/config) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/620dbcc5ab192992f08035fd9d271ffffb8ff043 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539 > git checkout 620dbcc5ab192992f08035fd9d271ffffb8ff043 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Link: https://lore.kernel.org/oe-kbuild-all/202304200502.T4Waeqad-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > >>> io_uring/io_uring.c:2091:25: error: no member named 'rw' in 'struct io_kiocb' > if (!is_write || (req->rw.kiocb.ki_flags & IOCB_DIRECT)) > ~~~ ^ > 1 error generated. The patch just can't work. Looks like it was forward ported on an older kernel, but not even compiled on a recent kernel. There's no req->rw.kiocb, hasn't been the case since 5.19. And you also can't do layering violations like this, req->rw is rw.c private and cannot even be used in io_uring.c. -- Jens Axboe
