On 4/6/23 14:20, Pavel Begunkov wrote:
Instead of smp_mb() + __io_cqring_wake() in __io_cq_unlock_post_flush()
use equivalent io_cqring_wake(). With that we can clean it up further
and remove __io_cqring_wake().
I didn't notice patches 3 and 7 have the same subj. This one
should've better been called refactor io_cqring_wake().
Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
---
io_uring/io_uring.c | 6 ++----
io_uring/io_uring.h | 11 ++---------
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index fb7215b543cd..d4ac62de2113 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -640,10 +640,8 @@ static inline void __io_cq_unlock_post_flush(struct io_ring_ctx *ctx)
* it will re-check the wakeup conditions once we return we can safely
* skip waking it up.
*/
- if (!(ctx->flags & IORING_SETUP_DEFER_TASKRUN)) {
- smp_mb();
- __io_cqring_wake(ctx);
- }
+ if (!(ctx->flags & IORING_SETUP_DEFER_TASKRUN))
+ io_cqring_wake(ctx);
}
--
Pavel Begunkov
