Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> writes: > On Fri, Feb 03, 2023 at 11:03:09AM -0800, Stefan Roesch wrote: >> This adds two example programs to test the napi busy poll functionality. >> It consists of a client program and a server program. To get a napi id, >> the client and the server program need to be run on different hosts. >> >> To test the napi busy poll timeout, the -t needs to be specified. A >> reasonable value for the busy poll timeout is 100. By specifying the >> busy poll timeout on the server and the client the best results are >> accomplished. >> >> Signed-off-by: Stefan Roesch <shr@xxxxxxxxxxxx> > > Those two break liburing's upstream CI. Also, it has many whitespace > issues: > > Applying: liburing: add example programs for napi busy poll > .git/rebase-apply/patch:258: space before tab in indent. > avgRTT += ctx->rtt[i]; > .git/rebase-apply/patch:382: space before tab in indent. > fprintf(stderr, "inet_pton error for %s\n", optarg); > .git/rebase-apply/patch:391: space before tab in indent. > fprintf(stderr, "socket() failed: (%d) %s\n", errno, strerror(errno)); > .git/rebase-apply/patch:392: space before tab in indent. > exit(1); > .git/rebase-apply/patch:794: space before tab in indent. > fprintf(stderr, "inet_pton error for %s\n", optarg); > warning: squelched 2 whitespace errors > warning: 7 lines add whitespace errors. > > ----------------------------------------------------------- > > napi-busy-poll-client.c:65:15: error: no previous extern declaration for non-static variable 'longopts' [-Werror,-Wmissing-variable-declarations] > struct option longopts[] = > ^ > napi-busy-poll-client.c:65:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct option longopts[] = > ^ > napi-busy-poll-client.c:435:28: error: comparison of integers of different signs: 'int' and '__u32' (aka 'unsigned int') [-Werror,-Wsign-compare] > if (opt.timeout != napi.busy_poll_to || > ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~ > napi-busy-poll-client.c:50:3: error: no previous extern declaration for non-static variable 'ctx' [-Werror,-Wmissing-variable-declarations] > } ctx; > ^ > napi-busy-poll-client.c:33:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct ctx > ^ > napi-busy-poll-client.c:63:3: error: no previous extern declaration for non-static variable 'options' [-Werror,-Wmissing-variable-declarations] > } options; > ^ > napi-busy-poll-client.c:52:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct options > ^ > 4 errors generated. > make[1]: *** [Makefile:38: napi-busy-poll-client] Error 1 > make[1]: *** Waiting for unfinished jobs.... > napi-busy-poll-server.c:64:15: error: no previous extern declaration for non-static variable 'longopts' [-Werror,-Wmissing-variable-declarations] > struct option longopts[] = > ^ > napi-busy-poll-server.c:64:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct option longopts[] = > ^ > napi-busy-poll-server.c:110:32: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > static void setProcessScheduler() > ^ > void > napi-busy-poll-server.c:48:3: error: no previous extern declaration for non-static variable 'ctx' [-Werror,-Wmissing-variable-declarations] > } ctx; > ^ > napi-busy-poll-server.c:32:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct ctx > ^ > napi-busy-poll-server.c:62:3: error: no previous extern declaration for non-static variable 'options' [-Werror,-Wmissing-variable-declarations] > } options; > ^ > napi-busy-poll-server.c:50:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit > struct options > ^ > 4 errors generated. > make[1]: *** [Makefile:38: napi-busy-poll-server] Error 1 > make[1]: Leaving directory '/home/runner/work/liburing/liburing/examples' > make: *** [Makefile:12: all] Error 2 > Error: Process completed with exit code 2. Do you happen to know which compiler and what settings are used in the CI environment? I don't see these warnings in my local environment.
