On 12/28/22 9:19?AM, Stefan Metzmacher wrote: > Hi Jens, > > any change to get some feedback on these? > https://lore.kernel.org/io-uring/60ce8938-77ed-0b43-0852-7895140c3553@xxxxxxxxx/ > and > https://lore.kernel.org/io-uring/c9a5b180-322c-1eb6-2392-df9370aeb45c@xxxxxxxxx/ > > Thanks in advance! Finally getting around to this after the break... I think your initial patch looks reasonable for doing cancel-on-close. Can you resubmit it against for-6.3/io_uring so we can get it moving forward, hopefully? That would also be a good point to discuss the fixed file case as well, as ideally this should obviously work on both types. -- Jens Axboe