From: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx> Currently, the default liburing compilation uses libc as its dependency. liburing doesn't depend on libc when it's compiled on x86-64, x86 (32-bit), and aarch64. There is no benefit to having libc.so linked to liburing.so on those architectures. Always enable CONFIG_NOLBIC if the arch is supported. If the architecture is not supported, fallback to libc. Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx> Co-authored-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> --- configure | 40 +++++++++++++++++++++++++++++++++++----- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4d9e99c..2033e6f 100755 --- a/configure +++ b/configure @@ -5,6 +5,22 @@ set -e cc=${CC:-gcc} cxx=${CXX:-g++} +# +# TODO(ammarfaizi2): Remove this notice and `--nolibc` option. +# +nolibc_deprecated() { + echo ""; + echo "================================================================="; + echo ""; + echo " --nolibc option is deprecated and has no effect."; + echo " It will be removed in a future liburing release."; + echo ""; + echo " liburing on x86-64, x86 (32-bit) and aarch64 always use CONFIG_NOLIBC."; + echo ""; + echo "================================================================="; + echo ""; +} + for opt do optarg=$(expr "x$opt" : 'x[^=]*=\(.*\)' || true) case "$opt" in @@ -26,7 +42,7 @@ for opt do ;; --cxx=*) cxx="$optarg" ;; - --nolibc) liburing_nolibc="yes" + --nolibc) nolibc_deprecated ;; *) echo "ERROR: unknown option $opt" @@ -385,13 +401,27 @@ fi print_config "NVMe uring command support" "$nvme_uring_cmd" ############################################################################# +# +# Currently, CONFIG_NOLIBC is only enabled on x86-64, x86 (32-bit) and aarch64. +# +cat > $TMPC << EOF +int main(void){ +#if defined(__x86_64__) || defined(__i386__) || defined(__aarch64__) + return 0; +#else +#error libc is needed +#endif +} +EOF +if compile_prog "" "" "nolibc support"; then + liburing_nolibc="yes" +fi +print_config "nolibc support" "$liburing_nolibc"; +############################################################################# + if test "$liburing_nolibc" = "yes"; then output_sym "CONFIG_NOLIBC" -else - liburing_nolibc="no" fi -print_config "liburing_nolibc" "$liburing_nolibc" - if test "$__kernel_rwf_t" = "yes"; then output_sym "CONFIG_HAVE_KERNEL_RWF_T" fi -- Ammar Faizi