On 11/24/22 9:16?AM, Pavel Begunkov wrote: > On 11/21/22 14:52, Jens Axboe wrote: >> __io_cq_unlock_post() is identical to io_cq_unlock_post(), and >> io_cqring_ev_posted() has a single caller so migth as well just inline >> it there. > > It was there for one purpose, to inline it in the hottest path, > i.e. __io_submit_flush_completions(). I'll be reverting it back The compiler is most certainly already doing that, in fact even __io_submit_flush_completions() is inlined in io_submit_flush_completions() for me here. -- Jens Axboe