From: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> Hi Jens, This series is a -Wmissing-prototypes enforcement. -Wmissing-prototypes is a clang C compiler flag that warns us if we have functions or variables that are not used outisde the translation unit, but not marked as static. This enforcement is good because it hints the compiler to do escape analysis and optimization better. There are 7 patches in this series. - Patch 1 is a core library change. Export __io_uring_flush_sq(). - Patch 2 to 6 are cleanups preparation before enforcing -Wmissing-prototypes. - Patch 7 is to add `-Wmissing-prototypes` for GitHub CI bot. This series has been build tested each patch with the GitHub CI robot and no breakage is found. Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> --- Ammar Faizi (7): liburing.h: Export `__io_uring_flush_sq()` function test/io_uring_setup: Remove unused functions ucontext-cp: Remove an unused function tests: Mark internal functions as static ucontext-cp: Mark internal functions as static test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags github: Add `-Wmissing-prototypes` for GitHub CI bot .github/workflows/build.yml | 7 ++-- examples/ucontext-cp.c | 19 +-------- src/include/liburing.h | 1 + src/liburing.map | 5 +++ test/Makefile | 11 ++++- test/accept-link.c | 2 +- test/accept-reuse.c | 9 ++-- test/ce593a6c480a.c | 4 +- test/defer-taskrun.c | 2 +- test/exit-no-cleanup.c | 2 +- test/hardlink.c | 2 +- test/io_uring_setup.c | 83 ++----------------------------------- test/link_drain.c | 2 +- test/multicqes_drain.c | 27 +++++++----- test/nvme.h | 3 +- test/poll-link.c | 2 +- test/poll-mshot-overflow.c | 2 +- test/read-before-exit.c | 2 +- test/ring-leak2.c | 2 +- test/sq-poll-kthread.c | 2 +- test/sqpoll-cancel-hang.c | 2 +- test/symlink.c | 3 +- test/timeout-new.c | 12 ++++-- 23 files changed, 70 insertions(+), 136 deletions(-) base-commit: b90a28636e5b5efe6dc1383acc90aec61814d9ba -- Ammar Faizi
