Hi Jens,
and needs a '#define HAVE_LINUX_TIME_TYPES_H 1' BTW, the original commit I posted was here: https://lore.kernel.org/io-uring/c7782923deeb4016f2ac2334bc558921e8d91a67.1666605446.git.metze@xxxxxxxxx/
I'll push a better version soon, it inverts the ifdef logic like this: --- a/include/uapi/linux/io_uring.h +++ b/include/uapi/linux/io_uring.h @@ -10,7 +10,15 @@ #include <linux/fs.h> #include <linux/types.h> +/* + * this file is shared with liburing and that has to autodetect + * if linux/time_types.h is available or not, it can + * define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H + * if linux/time_types.h is not available + */ +#ifndef UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H #include <linux/time_types.h> +#endif It also means that projects without liburing usage are not affected. And developers only have to care if they want to build on legacy systems without time_types.h Once that's accepted into the kernel I'll adjust the logic in liburing Does that sound like a plan? metze
