On Mon, Nov 07, 2022 at 09:05:12PM -0800, Jonathan Lemon wrote: > +struct io_zctap_buf *io_zctap_get_buf(struct io_zctap_ifq *ifq, int refc) > +{ > + return NULL; > +} > +EXPORT_SYMBOL(io_zctap_get_buf); > + > +void io_zctap_put_buf(struct io_zctap_ifq *ifq, struct io_zctap_buf *buf) > +{ > +} > +EXPORT_SYMBOL(io_zctap_put_buf); Adding stubs without anything in them is rather pointless. Also why are these exported? I can't find any modular users anywhere. Even if so, any low-level uring zero copy functionality should be EXPORT_SYMBOL_GPL, and only added once the modular users show up and are discussed.