On 11/9/22 1:18 AM, Keith Busch wrote:
On Tue, Nov 08, 2022 at 09:21:37AM -0800, Dylan Yudaken wrote:
Alphabetical order is commanded by the comment at the top of the list
We could create a make target to detect this kind of thing. A quick
script off the top of my head gets pretty close to finding improper
order, though not sure how pedantic it needs to be with the dashes '-'.
$ diff -u <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g') \
<(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g' | sort)
Good idea, we can also do this checking in our CI.
--
Ammar Faizi
