On 10/20/22 5:12 AM, Ammar Faizi wrote: > On 10/20/22 6:52 PM, Ammar Faizi wrote: >> From: Dylan Yudaken<dylany@xxxxxx> >> >> liburing has a couple of int shortening issues found by clang. Clean >> them all. This cleanup is particularly useful for build systems that >> include these files and run with that error enabled. >> >> Link:https://lore.kernel.org/io-uring/20221019145042.446477-1-dylany@xxxxxxxx >> Signed-off-by: Dylan Yudaken<dylany@xxxxxx> >> Co-authored-by: Ammar Faizi<ammarfaizi2@xxxxxxxxxxx> >> Signed-off-by: Ammar Faizi<ammarfaizi2@xxxxxxxxxxx> > > BTW, before it's too late. I think we should be consistent on the cast > style: > > (type) a > > or > > (type)a > > What do you think? I tend to prefer (type) a, but sometimes if you have multiple casts or the lines become too long, I'll do (type)a. I don't think it's super important in terms of style, as it isn't that prevalent. -- Jens Axboe
