On 9/23/22 8:32 AM, Dylan Yudaken wrote: > On Fri, 2022-09-23 at 14:53 +0100, Pavel Begunkov wrote: >> Overflowing CQEs may result in reordeing, which is buggy in case of >> links, F_MORE and so. >> > > Maybe the commit message got cut off? > > > I think this is probably ok, the downside being that CQE's with no > ordering constraints will have ordering forced on them. An alternative > would be for each case (eg linked, zerocopy, multishot) to either pause > or force CQE's to be overflow ones. This wouldnt slow down the other > codepaths. I don't have an idea for how difficult this might be. I don't think this matters at all. If you hit overflow, things are screwed and slow anyway. Doesn't make sense to optimize for that path, so we may as well impose ordering for everything at that point. -- Jens Axboe
