On 9/2/22 6:07 AM, Pavel Begunkov wrote: > On 9/2/22 13:03, Jens Axboe wrote: >> On 9/2/22 6:01 AM, Ammar Faizi wrote: >>> On 9/2/22 6:56 PM, Ammar Faizi wrote: >>>> On 9/2/22 6:12 PM, Pavel Begunkov wrote: >>>>> Fix up helpers and tests to match API changes and also add some more tests. >>>>> >>>>> Pavel Begunkov (4): >>>>> ??? tests: verify that send addr is copied when async >>>>> ??? zc: adjust sendzc to the simpler uapi >>>>> ??? test: test iowq zc sends >>>>> ??? examples: adjust zc bench to the new uapi >>>> >>>> Hi Pavel, >>>> >>>> Patch #2 and #3 are broken, but after applying patch #4, everything builds >>>> just fine. Please resend and avoid breakage in the middle. >>>> >>>> Thanks! >>> >>> Nevermind. It's already upstream now. >> >> Ah shoot, how did I miss that... That's annoying. > > We can squash them into a single commit if we care about it. > Don't really want do the disable + fix +e nable dancing here. It's already pushed out, so whatever is there is set in stone... Not a huge deal, but would've been nice to avoid. It's problematic when someone needs to bisect and issue and runs into a non-compiling step. Makes that process a lot more annoying, so yes we definitely do care about not introducing build breakage in a series of patches. -- Jens Axboe
