On Fri, Aug 12, 2022 at 5:46 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> - Small series improving type safety of the sqe fields (Stefan)
This doesn't work AT ALL.
A basic allmodconfig build fails with tons of errors. It starts with
In function ‘io_kiocb_cmd_sz_check’,
inlined from ‘io_prep_rw’ at io_uring/rw.c:38:21:
././include/linux/compiler_types.h:354:45: error: call to
‘__compiletime_assert_802’ declared with attribute error: BUILD_BUG_ON
failed: cmd_sz > sizeof(struct io_cmd_data)
354 | _compiletime_assert(condition, msg,
__compiletime_assert_, __COUNTER__)
| ^
././include/linux/compiler_types.h:335:25: note: in definition of
macro ‘__compiletime_assert’
335 | prefix ## suffix();
\
| ^~~~~~
././include/linux/compiler_types.h:354:9: note: in expansion of
macro ‘_compiletime_assert’
354 | _compiletime_assert(condition, msg,
__compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro
‘compiletime_assert’
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:50:9: note: in expansion of macro
‘BUILD_BUG_ON_MSG’
50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: "
#condition)
| ^~~~~~~~~~~~~~~~
./include/linux/io_uring_types.h:496:9: note: in expansion of macro
‘BUILD_BUG_ON’
496 | BUILD_BUG_ON(cmd_sz > sizeof(struct io_cmd_data));
| ^~~~~~~~~~~~
and goes downhill from there.
I don't think this can have seen any testing at all.
Linus
