On 27.07.22 22:53, Florian Fischer wrote:
On 27.07.2022 12:21, Bart Van Assche wrote:
On 7/27/22 08:27, Florian Fischer wrote:
11 files changed, 619 insertions(+), 4 deletions(-)
To me this diffstat tells me that this patch series adds a lot of complexity
instead of removing complexity.
That's because Jens wants to keep both build systems in the repository.
.github/workflows/build.yml | 44 +++++--
.gitignore | 2 +
Makefile | 84 ------------
Makefile.common | 6 -
Makefile.quiet | 11 --
configure | 467 -----------------------------------------------------------------
examples/Makefile | 41 ------
examples/meson.build | 19 +++
man/meson.build | 116 ++++++++++++++++
meson.build | 119 +++++++++++++++++
meson_options.txt | 14 ++
src/Makefile | 87 ------------
src/include/liburing/compat.h.in | 7 +
src/include/liburing/meson.build | 51 +++++++
src/include/meson.build | 3 +
src/meson.build | 28 ++++
test/Makefile | 238 ---------------------------------
test/meson.build | 219 +++++++++++++++++++++++++++++++
18 files changed, 609 insertions(+), 947 deletions(-)
This is what the diffstat could look like if we would remove the old build system.
To point this out explicitly:
old Makefile-based build system: 947 LoC
new Meson-based build system: 609 LoC
That is a significant reduction in build-system complexity, while the
new Meson-based build system has more features, e.g., out-of-source
builds and a sensible test framework. For further features, see the
cover-letter of this patch set.
- Flow
