On 7/25/22 12:55 PM, Eli Schwartz wrote: > T_EXIT_ERROR is different. It doesn't mean the test ran, and reported > something wrong with the software (e.g. liburing). Instead, an ERROR > return value indicates that the test itself broke and cannot even be > relied on to accurately test for a bug/regression. For example, if that > test was designated as an expected failure, it still knows that in this > case, error != fail, and it won't ignore the result as an expected failure. > > Also in general, if you see test errors you know to look at bugs in the > testsuite instead of trying to debug the software. :) > > I added T_EXIT_ERROR because it may be useful, without knowing in > advance whether I would have cause to use it anywhere. It's a valid > possible state. I think we should kill that, it just causes confusion and I generally hate adding infrastructure that isn't even being used. Besides, I don't see it being useful at all. Yes, tests could eg return T_EXIT_ERROR if io_uring_get_sqe() return NULL and it should not have. In reality, that's just a test failure and you need to look into why that happened anyway. As such, I don't think it's a useful distinction at all. Nobody is ever going to be writing tests and be making that distinction. -- Jens Axboe
