On 7/25/22 6:33 PM, Pavel Begunkov wrote:
Add helpers for notification registration and preparing zerocopy send requests. Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx> --- src/include/liburing.h | 42 ++++++++++++++++++++++++++++++++++++++++++ src/liburing.map | 2 ++ src/register.c | 20 ++++++++++++++++++++ 3 files changed, 64 insertions(+)
[...]
+static inline void io_uring_prep_notif_update(struct io_uring_sqe *sqe, + __u64 new_tag, /* 0 to ignore */ + unsigned offset, unsigned nr) +{ + io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, 0, nr, + (__u64)offset); + sqe->addr = new_tag; + sqe->ioprio = IORING_RSRC_UPDATE_NOTIF; +}
The same nit on there. But overall it looks good. Reviewed-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> -- Ammar Faizi