On Thu, Jul 21, 2022 at 09:59:40AM -0600, Jens Axboe wrote: > On 7/21/22 9:37 AM, Christoph Hellwig wrote: > > Hi Jens, > > > > is there any good reason __io_file_supports_nowait checks the > > blk_queue_nowait flag for regular files? The FMODE_NOWAIT is set > > for regular files that support nowait I/O, and should be all that > > is needed. Even with a block device that does not nonblocking > > I/O some thing like reading from the page cache can be done > > non-blocking. > > Nope, we can probably kill that check then. Want to send a patch? What would be a good way to verify it doesn't break any strange assumptions? I kinda don't fell too comfortable touching io_uring guts. > > -- > Jens Axboe ---end quoted text---