On 6/30/22 15:31, Ammar Faizi wrote:
On 6/30/22 9:19 PM, Pavel Begunkov wrote:
On 6/30/22 14:09, Jens Axboe wrote:
On 6/30/22 3:13 AM, Pavel Begunkov wrote:
@@ -949,5 +1114,11 @@ int main(int argc, char *argv[])
return ret;
}
+ ret = test_file_alloc_ranges();
+ if (ret) {
+ printf("test_partial_register_fail failed\n");
+ return ret;
+ }
If you're returning this directly, test_file_alloc_ranges() should use
the proper T_EXIT_foo return codes.
Nobody cared enough to "fix" all tests to use those new codes, most
of the cases just return what they've got, but whatever. Same with
stdout vs stderr.
That error code rule was invented since commit:
68103b731c34a9f83c181cb33eb424f46f3dcb94 ("Merge branch 'exitcode-protocol' of ....")
Ref: https://github.com/axboe/liburing/pull/621/files
Thanks to Eli who did it. Eli also fixed all tests. Maybe some are still
missing, but if we find it, better to fix it.
Have no idea what you're talking about but I'm having
hard time calling 6 returns out of 21 in this file "all".
--
Pavel Begunkov
