On 6/14/22 7:01 AM, Pavel Begunkov wrote: > On 6/14/22 13:52, Jens Axboe wrote: >> On 6/14/22 6:29 AM, Pavel Begunkov wrote: >>> io-wq doesn't use ->cancel_seq, it's only important to io_uring and >>> should be stored there. >> >> It isn't there because it's io-wq only, but to save space. This adds 8 >> bytes to io_kiocb, as far as I can tell? > > Ah ok, makes sense. It's worth a comment though Definitely, not sure why I didn't add one... When you respin the series, maybe change this patch to add that comment instead? -- Jens Axboe