On 6/2/22 1:18 AM, cgel.zte@xxxxxxxxx wrote: > diff --git a/fs/io_uring.c b/fs/io_uring.c > index 1fc0166d9133..d1fe967f2343 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -4445,8 +4445,7 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags) > kiocb_done(req, ret, issue_flags); > out_free: > /* it's faster to check here then delegate to kfree */ > - if (iovec) > - kfree(iovec); > + kfree(iovec); > return 0; > } There is _literally_ a comment right above your change that explains why this is there. Please read surrounding code, at least. -- Jens Axboe
