> On 5/30/22 10:15 AM, Xiaoguang Wang wrote: >> hi, >> >>> On 5/30/22 7:18 AM, Jens Axboe wrote: >>>> On 5/30/22 7:15 AM, Xiaoguang Wang wrote: >>>>> @@ -5945,16 +5948,22 @@ static int io_statx(struct io_kiocb *req, unsigned int issue_flags) >>>>> return 0; >>>>> } >>>>> >>>>> +#define IORING_CLOSE_FD_AND_FILE_SLOT 1 >>>>> + >>>> This should go into uapi/linux/io_uring.h - I'll just move it, no need >>>> for a v3 for that. Test case should add it too. >>> Here's what I merged so far: >>> >>> https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.19&id=f6b0e7c95c20d4889b811ada7fc0061e8cb4e82e >>> >>> Changes: >>> >>> - I re-wrote the commit message slightly >>> - Move flag to header where it belongs >>> - Get rid of 'goto' in io_files_update_with_index_alloc() >>> - Drop unneeded variable in io_files_update_with_index_alloc() >> I think file registration feature is much easier to use now, thanks! > Thanks for making the change! Will you send a v2 of the liburing test? Yeah, I'll do it, will send it soon. Regards, Xiaoguang Wang > Then I'll get that queued up too. >
