On 5/9/22 9:15 PM, Jens Axboe wrote: > On 5/8/22 9:43 AM, Hao Xu wrote: >> Sorry for polluting the list, not sure why the cover-letter isn't >> wired with the other patches.. > > Yeah not sure what's going on, but at least they are making it > through... Maybe we should base this on the > for-5.19/io_uring-alloc-fixed branch? The last patch needs to be updated > for that anyway. I'd think the only sane check there now is if it's a > multishot direct accept request, then the request must also specify > IORING_FILE_INDEX_ALLOC to ensure that we allocate descriptors. Oh, and I'm assuming you added some comprehensive tests for this for liburing? Both functionally, but also checking the cases that should fail (like mshot + fixed without alloc, etc). When you send out the next/final version, would be great if you could do a the same for the liburing side. -- Jens Axboe
