On 5/9/22 12:00 AM, Christoph Hellwig wrote: > On Sat, May 07, 2022 at 06:53:30AM -0600, Jens Axboe wrote: >> How about we just add a comment? We use it in two spots, but one has >> knowledge of the sqe64 vs sqe128 state, the other one does not. Hence >> not sure how best to add a helper for this. One also must be a compile >> time constant. Best I can think of is the below. Not the prettiest, but >> it does keep it in one spot and with a single comment rather than in two >> spots. > > If you think just a comment is better I can live with that, also the > proposed macro also looks fine to me. I folded in the macro patch, seems safer and better to just have a single spot where it's done rather than rely on two comments if things do change there in the future. -- Jens Axboe
