On 5/5/22 1:50 PM, hch@xxxxxx wrote: > On Thu, May 05, 2022 at 01:31:28PM -0600, Jens Axboe wrote: >>>> Jens Axboe >>> >>> This does work and got me past the null ptr segfault. >> >> OK good, thanks for testing. I did fold it in. > > It might make sense to just kill nvme_meta_from_bio and pass the > meta pointer directly with this version of the code. Do you want to do an incremental for that? Looking at nvme_execute_user_rq() and nvme_uring_task_cb() there's a fair bit of duplication of the meta copy. -- Jens Axboe