On 5/4/22 9:12 AM, Kanchan Joshi wrote:
>> @@ -64,16 +63,19 @@ struct io_uring_sqe {
>> __u32 file_index;
>> };
>> union {
>> - __u64 addr3;
>> - __u64 cmd;
>> + struct {
>> + __u64 addr3;
>> + __u64 __pad2[1];
>> + } small;
>
> Thinking if this can cause any issue for existing users of addr3, i.e.
> in the userspace side? Since it needs to access this field with
> small.addr3.
> Jens - is xattr infra already frozen?
It's not, as it's not upstream yet. But I don't think we need to change
it, just make the two structs unnamed instead. That also avoids awkward
small/big prefixes.
--
Jens Axboe
