On Tue, May 03, 2022 at 08:48:30PM +0200, Pankaj Raghav wrote: > operation NVME_URING_CMD_IO. This operates on a new structure > nvme_uring_cmd, which is similiar to struct nvme_passthru_cmd64 but > without the embedded 8b result field. This is not needed since uring-cmd > allows to return additional result to user-space via big-CQE. So let's have a discussion for everyone on whether to reuse the existing struct or not. Pros for reusing: - any application that is passing around a nvme_passthru_cmd64 doesn't need to do special marshalling Cons: - these fields are pointless I'm fine going either way, we just need to think about the implications. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
