On 4/24/22 12:22 AM, Kanchan Joshi wrote: > On Sat, Apr 23, 2022 at 12:06:05PM -0600, Jens Axboe wrote: >> On 4/22/22 4:10 AM, Kanchan Joshi wrote: >>> Move common error-handling to io_req_complete, so that various callers >>> avoid repeating that. Few callers (io_tee, io_splice) require slightly >>> different handling. These are changed to use __io_req_complete instead. >> >> This seems incomplete, missing msgring and openat2 at least? I do like >> the change though. Care to respin a v2? > > But both (io_msg_ring, and io_openat2) are already using > __io_req_complete (and not io_req_complete). So nothing is amiss? Yeah, I guess it's actually fine like that, and would in any case require more changes to unify the rest. So let's just go with this for now. -- Jens Axboe
