On 4/17/22 6:05 PM, Jens Axboe wrote: > On 4/15/22 3:08 PM, Pavel Begunkov wrote: >> @@ -1337,21 +1342,21 @@ static inline void io_req_put_rsrc_locked(struct io_kiocb *req, >> if (node == ctx->rsrc_node) >> ctx->rsrc_cached_refs++; >> else >> - percpu_ref_put(&node->refs); >> + io_rsrc_put_node(node, 1); >> } >> } >> >> static inline void io_req_put_rsrc(struct io_kiocb *req, struct io_ring_ctx *ctx) >> { >> if (req->rsrc_node) >> - percpu_ref_put(&req->rsrc_node->refs); >> + io_rsrc_put_node(req->rsrc_node, 1); >> } > > What's this against? I have req->fixed_rsrc_refs here. > > Also, typo in subject s/hepler/helper. As far as I can tell, this patch doesn't belong in this series and not sure what happened here? But for that series, let's drop 'ctx' from io_req_put_rsrc() as well as it's unused. -- Jens Axboe