Re: [PATCH 4/4] io_uring: optimise compl locking for non-shared rings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/18/22 9:32 AM, Pavel Begunkov wrote:
>>>> work with registered files (and ring fd) as that is probably a bigger
>>>> win than skipping the completion_lock if you're not shared anyway.
>>>
>>> It does work with fixed/registered files and registered io_uring fds.
>>
>> t/io_uring fails for me with registered files or rings, getting EINVAL.
>> Might be user error, but that's simply just setting CQ_PRIVATE for
>> setup.
> 
> One thing I changed in the tool is that the ring should be created
> by the submitter task, so move setup_ring into the submitter thread.
> Plan to get rid of this restriction though.

OK, thought it was probably something like that, you do end up with two
tctx if you init in main and pass to thread. But that's probably quite a
common way to do setup, so should deal with that in the future at least.
Just part of the stuff that would ultimately need polishing.

> Weird that it works only for you only without reg files/rings, will
> take a look.

I think the part above totally explains it.

> Attached io_uring.c that I used, it's based on some old version,
> so do_nop can't be set in argv but should turned in the source code.
> IORING_ENTER_REGISTERED_RING is always enabled.

Thanks!

-- 
Jens Axboe




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux