On 3/15/22 2:48 PM, Dylan Yudaken wrote: > Make the tracing formatting for user_data and flags consistent. > > Having consistent formatting allows one for example to grep for a specific > user_data/flags and be able to trace a single sqe through easily. > > Change user_data to be %llu everywhere, and flags to be %u. Additionally > remove the '=' for flags in io_uring_req_failed, again for consistency. Shouldn't we rather make flags be %x everywhere? Doesn't make a lot of sense to have a flag based value be in decimal. Ditto on user_data actually, I would guess the most common use case is stuffing an address in there. And if it's a masked value, then it's easier to read in hex too. Hmm? -- Jens Axboe
