On 1/30/22 1:32 AM, Jens Axboe wrote:
On 1/29/22 5:50 AM, Ammar Faizi wrote:Hello, This patchset adds sendto(2) and recvfrom(2) support for io_uring. It also addresses an issue in the liburing GitHub repository [1]. ## Motivations: 1) By using `sendto()` and `recvfrom()` we can make the submission simpler compared to always using `sendmsg()` and `recvmsg()` from the userspace. Especially for UDP socket. 2) There is a historical patch that tried to add the same functionality, but did not end up being applied. [2]As far as I can tell, the only win from sendto/recvfrom is that we can handle async offload a bit cheaper compared to sendmsg/recvmsg. Is this enough to warrant adding them separately? I don't know, which is why this has been somewhat stalled for a while. Maybe you have done some testing and have numbers (or other reasons) to back up the submission? There's not a whole lot of justification in this patchset.
So far, I haven't done it. I only created a test that ensures the functionality is working properly. I will play with this further. If I win, I will submit the v2 of this series for review. Thanks, Jens! -- Ammar Faizi
