Re: [PATCH bpf-next v2 01/10] io_uring: Implement eBPF iterator for registered buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kumar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Introduce-BPF-iterators-for-io_uring-and-epoll/20211123-065555
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: hexagon-randconfig-r045-20211122 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c133fb321f7ca6083ce15b6aa5bf89de6600e649)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/69cd86892cc99ed54a77816b3c4d78429150339c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/Introduce-BPF-iterators-for-io_uring-and-epoll/20211123-065555
        git checkout 69cd86892cc99ed54a77816b3c4d78429150339c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/io_uring.c:11190:6: warning: no previous prototype for function 'bpf_io_uring_iter_show_fdinfo' [-Wmissing-prototypes]
   void bpf_io_uring_iter_show_fdinfo(const struct bpf_iter_aux_info *aux,
        ^
   fs/io_uring.c:11190:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void bpf_io_uring_iter_show_fdinfo(const struct bpf_iter_aux_info *aux,
   ^
   static 
>> fs/io_uring.c:11197:5: warning: no previous prototype for function 'bpf_io_uring_iter_fill_link_info' [-Wmissing-prototypes]
   int bpf_io_uring_iter_fill_link_info(const struct bpf_iter_aux_info *aux,
       ^
   fs/io_uring.c:11197:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int bpf_io_uring_iter_fill_link_info(const struct bpf_iter_aux_info *aux,
   ^
   static 
   2 warnings generated.


vim +/bpf_io_uring_iter_show_fdinfo +11190 fs/io_uring.c

 11188	
 11189	#ifdef CONFIG_PROC_FS
 11190	void bpf_io_uring_iter_show_fdinfo(const struct bpf_iter_aux_info *aux,
 11191					   struct seq_file *seq)
 11192	{
 11193		seq_printf(seq, "io_uring_inode:\t%lu\n", aux->io_uring.inode);
 11194	}
 11195	#endif
 11196	
 11197	int bpf_io_uring_iter_fill_link_info(const struct bpf_iter_aux_info *aux,
 11198					     struct bpf_link_info *info)
 11199	{
 11200		info->iter.io_uring.inode = aux->io_uring.inode;
 11201		return 0;
 11202	}
 11203	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux