On Thu, Oct 7, 2021 at 1:45 AM Bedirhan KURT <windowz414@xxxxxxxxxxx> wrote: > > Ammar, > > As you told me through Telegram, I have reviewed your patch but > aren't inclusions important for some functions and/or commands > to work on compiling process? > > I mean you surely know more about this but, from what I know > with my Android development experience, omitting/removing > inclusions and/or imports from files to be compiled or > scripts to be used might cause issues during > compilation/booting/usage process so I guess those > inclusions were just unnecessary? > > I'm also aware that Android is no match with Linux kernel but > I just wanted to point that out. > > Regards, > > Bedirhan KURT. > Hmmm... I don't fully understand your comment. But as far as I can tell, those inclusions are duplicate. We have them in the lib.h and syscall.h after these patches. If this removal caused a compilation problem, I would have caught that before sending these patches as I've at least built it. -- Ammar Faizi
