On 10/6/21 9:06 AM, Pavel Begunkov wrote: > Looking at the assembly, the compiler decided to reload req->opcode in > io_op_defs[opcode].needs_file instead of one it had in a register, so > store it in a temp variable so it can be optimised out. Also move the > personality block later, it's better for spilling/etc. as it only > depends on @sqe, which we're keeping anyway. > > By the way, zero req->opcode if it over IORING_OP_LAST, not a problem, > at the moment but is safer. That had me a bit worried, but you mean it's reloading req->opcode, not sqe->opcode. Phew. -- Jens Axboe
