Re: [PATCHSET v1 RFC liburing 0/6] Implement the kernel style return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 1, 2021 at 1:44 PM Louvian Lyndal <louvianlyndal@xxxxxxxxx> wrote:
> This will add extra call just to wrap the libc. Consider to static
> inline them?
>
> For libc they just check the retval, if it's -1 then return -errno. If
> they are inlined, they are ideally identical with the previous version.
>
> Besides they are all internal functions. I don't see why should we
> pollute global scope with extra wrappers.
>

Yeah makes sense, I will address this for v2. We can have them as
static inline functions in `src/syscall.h`.

> Regards,
>
> --
> Louvian Lyndal



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux