On 9/24/21 10:14 AM, Pavel Begunkov wrote: > We don't retry short writes and so we would never get to async setup in > io_write() in that case. Thus ret2 > 0 is always false and > iov_iter_advance() is never used. Apparently, the same is found by > Coverity, which complains on the code. Thanks, applied. Should have a: Fixes: cd65869512ab ("io_uring: use iov_iter state save/restore helpers") which I added. -- Jens Axboe