On 9/18/21 11:21 PM, Jens Axboe wrote: > On 9/18/21 3:55 PM, Victor Stewart wrote: >>> BTW, this could be incorporated into io_uring_register_files and >>> io_uring_register_files_tags(), might not be a bad idea in general. Just >>> have it check rlim.rlim_cur for RLIMIT_NOFILE, and if it's smaller than >>> 'nr_files', then bump it. That'd hide it nicely, instead of throwing a >>> failure. >> >> the implicit bump sounds like a good idea (at least in theory?). > > Can you try current liburing -git? Remove your own RLIMIT_NOFILE and > just verify that it works. I pushed a change for it. Sounds like it pretty easy can be a very unexpected behaviour. Do many libraries / etc. implicitly tinker with it? >> another thing i think might be a good idea is an io_uring >> change/migration log that we update with every kernel release covering >> new features but also new restrictions/requirements/tweaks etc. > > Yes, that is a good idea. The man pages do tend to reference what > version included what, but a highlight per release would be a great idea > to have without having to dig for it. > >> something that would take 1 minute to skim and see if relevant. >> >> because at this point to stay fully updated requires reading all of the >> mailing list or checking pulls on your branch + running to binaries >> to see if anything breaks. > > Question is where to post it? Because I would post it here anyway... Good idea. We need it in a single file to be useful liburing/changelog.txt? -- Pavel Begunkov
