Question about async_wake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jens, Pavel,
I have a question about _async_wake(), would there be cases like
this:
   async_cancel/poll_remove           interrupt
     spin_lock_irq()
list del poll->wait_entry         event happens but irq disabled
                                  so interrupt delays
    spin_unlock_irq()
      generate cqe
                                  async_wake() called and
                                  generate cqe

If it exists, there may be multiple -ECANCELED cqes for one req,
we may do something like this to avoid it:

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 30d959416eba..7822b2f9e890 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5023,9 +5023,12 @@ static int __io_async_wake(struct io_kiocb *req, struct io_poll_iocb *poll,
        if (mask && !(mask & poll->events))
                return 0;

- trace_io_uring_task_add(req->ctx, req->opcode, req->user_data, mask);
+       if (list_empty(&poll->wait.entry))
+               return 0;
+       else
+               list_del_init(&poll->wait.entry);

-       list_del_init(&poll->wait.entry);
+ trace_io_uring_task_add(req->ctx, req->opcode, req->user_data, mask);

        req->result = mask;
        req->io_task_work.func = func;



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux