On Tue, Sep 07, 2021 at 10:17:53PM +0530, Kanchan Joshi wrote: > I'll do away with that comment. But sorry, what part do you think > should rather move to io_uring. Is that for the whole helper > "nvme_rq_map_user_fixed"? Yes. Nothing nvme-specific in it. Given that it only makes sense to be used for io_uring support moving it to io_uring.c might make sense. Or conditionally to block/blk-map.c.