On 9/7/21 9:16 AM, Hao Xu wrote: > check file_slot early in io_accept_prep() to avoid wasted effort in > failure cases. It's generally better to just let the failure cases deal with it instead of having checks in multiple places. This is a failure path, so we don't care about making it fail early. Optimizations should be for the hot path, which is not a malformed sqe. -- Jens Axboe