On 8/28/21 8:35 PM, Jens Axboe wrote:
> On 8/28/21 1:18 PM, Pavel Begunkov wrote:
>> Document
>> - IORING_REGISTER_FILES2
>> - IORING_REGISTER_FILES_UPDATE2,
>> - IORING_REGISTER_BUFFERS2
>> - IORING_REGISTER_BUFFERS_UPDATE,
>>
>> And add a couple of words on registered resources (buffers, files)
>> tagging.
>
> Just a few comments below.
Thanks for taking a look, not going to pretend that I'm good at it :)
[...]
>> +.PP
>> +.in +8n
>> +.EX
>> +struct io_uring_rsrc_register {
>> + __u32 nr;
>> + __u32 resv;
>> + __u64 resv2;
>> + __aligned_u64 data;
>> + __aligned_u64 tags;
>> +};
>
> Move this up to where it's initially mentioned?
Do you mean a couple of lines up? like this?
.I arg
points to a
.I struct io_uring_rsrc_register.
<struct definition section>
.I nr_args
should be set to the number of bytes in the structure.
--
Pavel Begunkov
