On 8/13/21 1:58 AM, Hao Xu wrote: > 在 2021/8/13 上午1:28, Jens Axboe 写道: >> On 8/11/21 10:14 PM, Hao Xu wrote: >>> Some small code clean. >>> >>> Hao Xu (3): >>> io_uring: extract io_uring_files_cancel() in io_uring_task_cancel() >>> io_uring: remove files pointer in cancellation functions >>> io_uring: code clean for completion_lock in io_arm_poll_handler() >>> >>> fs/io_uring.c | 15 ++++++--------- >>> include/linux/io_uring.h | 9 +++++---- >>> kernel/exit.c | 2 +- >>> 3 files changed, 12 insertions(+), 14 deletions(-) >> >> This looks good, except 3/3 which I think was rebased and then not >> re-tested after doing so... That's a black mark. >> > Actually I re-tested it after rebasing code and addressing the conflict > But the liburing tests results seems all good. Anyway, I'll check the > code more carefully when resolving conflict. Probably would only complain if you had PROVE_LOCKING enabled in your config. The last patch broke !CONFIG_IO_URING too, I fixed that up. -- Jens Axboe
