On Wed, Aug 11, 2021 at 01:35:28PM -0600, Jens Axboe wrote: > The memset() used is measurably slower in targeted benchmarks. Get rid > of it and fill in the bio manually, in a separate helper. If you have some numbers if would be great to throw them in here. > +static inline void __bio_init(struct bio *bio) Why is this split from bio_init and what are the criteria where an initialization goes? > + bio->bi_flags = bio->bi_ioprio = bio->bi_write_hint = 0; Please keep each initialization on a separate line.