On 7/23/21 8:31 AM, Pavel Begunkov wrote: > On 7/23/21 10:22 AM, Hao Xu wrote: >> For pure poll requests, we should remove the double poll wait entry. >> And io_poll_remove_double() is good enough for it compared with >> io_poll_remove_waitqs(). > > 5.14 in the subject hints me that it's a fix. Is it? > Can you add what it fixes or expand on why it's better? Ditto that, the commit message explains what is being done, it should explain _why_ it's being done. For the 'what' part you can read the code. So while the patch doesn't look wrong, I also can't quite tell why the change is necessary. -- Jens Axboe
