[ back looking at this from doing other merge window stuff ]
On Sat, Jul 3, 2021 at 8:27 AM Dmitry Kadashev <dkadashev@xxxxxxxxx> wrote:
>
> This is how I originally thought it is going to be, but Al suggested
> that it eats the name on the failure. Now that I spent slightly
> more time with it I *suspect* the reason (or a part of it) is making it
> keep the name on failure would require A LOT of changes, since a lot of
> functions that __filename_create() calls eat the name on failure.
Ok.
Let's try to keep the changes minimal and simple.
Your original approach with __filename_create() looks reasonable, if
we then just clean up the end result by making putname() ok with an
error pointer.
The odd conditional putname() calls were the main issue that made me
go "this is just very ugly and confusing"
How do the patches end up looking with just that cleanup (and some
clarifying comment about the very odd "out_putpath" case it had?)
Linus
