On 6/22/21 11:35 PM, Dmitry Kadashev wrote: > On Tue, Jun 22, 2021 at 6:56 PM Pavel Begunkov <asml.silence@xxxxxxxxx> wrote: >> >> On 6/3/21 6:18 AM, Dmitry Kadashev wrote: >>> This started out as an attempt to add mkdirat support to io_uring which >>> is heavily based on renameat() / unlinkat() support. >>> >>> During the review process more operations were added (linkat, symlinkat, >>> mknodat) mainly to keep things uniform internally (in namei.c), and >>> with things changed in namei.c adding support for these operations to >>> io_uring is trivial, so that was done too. See >>> https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/ >> >> io_uring part looks good in general, just small comments. However, I >> believe we should respin it, because there should be build problems >> in the middle. > > I knew my celebration was premature! :) It's all good, just respin with the requested fixes :-) -- Jens Axboe
