On 6/20/21 1:28 PM, Olivier Langlois wrote: > On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote: >> On 6/20/21 12:05 PM, Olivier Langlois wrote: >>> - return false; >>> + return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR; >> >> Hi, >> Please make that return expression more readable. >> >> > How exactly? > > by adding spaces? > Changing the define names?? Not super important, but I greatly prefer: if (ret) return IO_ARM_POLL_READY; return IO_ARM_POLL_ERR; as that's a lot more readable to me. This is orthogonal to the currently missing spaces, of course. For the defines, an enum would be preferable too. And place it near where it's used. -- Jens Axboe
