On Sun, 2021-06-20 at 21:08 +0100, Pavel Begunkov wrote: > On 6/20/21 9:01 PM, Randy Dunlap wrote: > > On 6/20/21 12:28 PM, Olivier Langlois wrote: > > > On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote: > > > > On 6/20/21 12:05 PM, Olivier Langlois wrote: > > > > > - return false; > > > > > + return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR; > > > > > > > > Hi, > > > > Please make that return expression more readable. > > > > > > > > > > > How exactly? > > > > > > by adding spaces? > > > Changing the define names?? > > > > Adding spaces would be sufficient IMO (like Pavel suggested also). > > Agree. That should be in the code style somewhere > Sure no problem. This hasn't been reported by checkpatch.pl but I have just discovered codespell... Maybe this addon reports more issues than vanilla checkpatch
