On 5/26/21 6:19 PM, Olivier Langlois wrote: > On Wed, 2021-05-26 at 12:18 -0400, Olivier Langlois wrote: >>> >>> If that gets changed, could be also include the personality id and >>> flags here, >>> and maybe also translated the opcode and flags to human readable >>> strings? >>> >> If Jens and Pavel agrees that they would like to see this info in the >> traces, I have no objection adding it. >> > I need to learn to think longer before replying... > > opcode in readable string: > If Jens and Pavel agrees to it, easy to add Don't mind having them, may be useful, but let's leave stringification to the userspace, values are well defined so shouldn't be a problem liburing maybe? > > flags: > You have my support that it is indeed a very useful info to have in the > submit_sqe trace when debugging with traces > > flags in readable string: > After thinking about it, I wouldn't do it. Converting a bitmask of > flags into a string isn't that complex but it isn't trivial neither. > This certainly adds a maintenance burden every time the flags would be > updated. I wouldn't want that burden on my shoulders. > > -- Pavel Begunkov
